Fix crash when using conda-pack on environments created with pixi #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
I wonder whether the non-existence of |
|
I don't think there is a specification of the conda-meta structure, only the conda implementation. I would argue that generating the conda-meta/history file makes little sense for pixi since environments are not mutated, so imho the best course of action is to make the file optional here. |
|
pre-commit.ci autofix |
xhochy
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to use conda-pack with environments created using pixi. This caused a few issues due to slight variations in the content of the conda-mata files. (E.g.
info['link']was "null" in my files, and I don't have aconda-meta/historyfile).Have added few checks to the code which makes conda-pack work with environments created with pixi.
I don't know if there is a standard for the conda-meta stuff. If so, the real fix should be in pixi of course. But I hope you will consider my PR anyway.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?